feature(signup): migrate simple-signup to standard browser#9969
Conversation
Rello
force-pushed
the
codex/add-nc-account-setup
branch
from
3478686 to
0c7cc33
Compare
Add NC URI handling for account setup and provider signup flow support. Signed-off-by: Rello <github@scherello.de>
Rello
force-pushed
the
codex/add-nc-account-setup
branch
from
0c7cc33 to
ba63b06
Compare
Bildschirmaufnahme.2026-05-08.um.13.41.36.movNote: |
|
looking at the video - this flow seems reasonable, yeah, it works for me. It's a little more involved, but if it makes things so much easier it is worth it. @jancborchardt agreed? |
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Sure, yeah this seems fine considering the dev effort this saves also.
A nice enhancement would be to open the simple signup page with a parameter that loads only the essentials there to make it super quick and not seem bloated. For example:
- No navigation, no footer (to not navigate away)
- No animation for the right block – currently that slows stuff down
- Focus "Your email address" field
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 618a6c5a35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| qCWarning(OCC::lcApplication) << "Could not dispatch macOS AppleEvent custom URI scheme request because qApp is not available yet."; | ||
| } |
There was a problem hiding this comment.
In URLEventHandler::handleURLEvent, the new if (qApp) ... else branch drops the URL entirely when qApp is null, which can happen during cold-start handling because this handler is explicitly registered before launch is complete (src/gui/cocoainitializer_mac.mm comment at lines 23-26, and CocoaInitializer is created before Application in src/gui/main.cpp). In that startup window, login/signup deep links are lost and never retried, so the URI flow can fail intermittently on macOS.
Useful? React with 👍 / 👎.
| const auto serverUrlValue = path.mid(QString::fromLatin1(loginServerPathPrefix).size()); | ||
| const auto serverUrl = QUrl{serverUrlValue}; |
There was a problem hiding this comment.
The new login parser treats everything after server: as a pure server URL (QUrl{serverUrlValue}), so links in the legacy format nc://login/server:<server>&user:<...>&password:<...> are rejected as invalid because &user... becomes part of serverUrlValue. That breaks compatibility for environments still emitting the legacy URI format during rollout, leaving provider signup/login links unhandled instead of falling back.
Useful? React with 👍 / 👎.
|
i2h3
added
os: 🍎 macOS
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
4 participants
Background
Overview
ocsapirequest(old desktop clients & mobile clients) is not touched. In this case, the Nextcloud will return anc://login/server:{server}&user:{email}&password:{appPassword}responseflow=V3, the user is logged in in the webUI and additionally, anc://login/server:{server}response is triggeredChanges to desktop
This pull request depends on the following pull requests to be merged first: